Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setting filter handling logs to trace #2914

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

gabrielmer
Copy link
Contributor

Description

Setting filter handler logs to trace for cases in which we don't have anywhere to push the messages.

Issue

closes #2907

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2914

Built from df3961b

@gabrielmer gabrielmer marked this pull request as ready for review July 17, 2024 08:48
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I failed to remember that "no subscribed peers found" is a warn.
Trace is ok, but mostly still useless unless we are actually debugging filter service...
So it is big yess!

@gabrielmer gabrielmer merged commit 5c539fe into master Jul 17, 2024
9 of 11 checks passed
@gabrielmer gabrielmer deleted the chore-log-cleanup branch July 17, 2024 10:29
Ivansete-status pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: reduce loglevel to some too frequent or unnecessary logs
3 participants